Fixes: #369

Signed-off-by: Trey Aspelund <[email protected]>

Signed-off-by: Trey Aspelund <[email protected]>

Import/Export filters are meant to modify which advertised prefixes
are allowed. For Import, this is simply an allow-list that accepts a
subset of the advertised nlri in a received update. For Export, this
is an allow-list that accepts a subset of the locally originated nlri.
In neither case do you want to apply these filters to the list of
withdrawn nlri, as this can result in stale routes if a legitimate
withdrawal is not sent or received.

Fixes: #330

Signed-off-by: Trey Aspelund <[email protected]>

Removes an unused function.
Guards an illumos-specific import.
Consolidates (bfd) nexthop enabled functions into one that takes a bool.
Moves RIB locking and looping of prefixes and PrefixChangeNotifications
into RIB removal helper functions to improve pcn batching and
consolidate locations for future RIB batch work.
Removes re-processing of BGP path attributes.
Removes re-looping over routes/paths in a few places.
Eliminates some return types when no callers handled Result.
Adds some TODOs.

Signed-off-by: Trey Aspelund <[email protected]>

Signed-off-by: Trey Aspelund <[email protected]>

mgd/src/bgp_admin.rs was re-defining lock! identically to the one in
mg-common.  Remove this dupe definition and just import from mg-common.

Signed-off-by: Trey Aspelund <[email protected]>

Replace all old instances of .lock().unwrap() with lock!()

Signed-off-by: Trey Aspelund <[email protected]>

Signed-off-by: Trey Aspelund <[email protected]>

Signed-off-by: Trey Aspelund <[email protected]>

Actually run the same cargo clippy command as CI, so I can see
errors locally :/

Signed-off-by: Trey Aspelund <[email protected]>

Signed-off-by: Trey Aspelund <[email protected]>