Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop building rot-prod-rel/rot-staging-dev repos #5316

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Mar 23, 2024

No description provided.

@iliana
Copy link
Contributor Author

iliana commented Mar 23, 2024

Seems like it worked first try?

Diffing the tufaceous manifests from #5313 and this run

Looks like we don't sort the list of zones, heh. But everything seems to be there.

$ diff -u 5313-manifest.toml 5316-manifest.toml
--- 5313-manifest.toml  2024-03-23 12:15:47
+++ 5316-manifest.toml  2024-03-23 12:15:42
@@ -1,52 +1,52 @@
-system_version = "7.0.0-0.ci+git26fad698030"
+system_version = "7.0.0-0.ci+gitb4e1a285ef8"

 [[artifact.control_plane]]
 name = "control-plane"
-version = "7.0.0-0.ci+git26fad698030"
+version = "7.0.0-0.ci+gitb4e1a285ef8"
 [artifact.control_plane.source]
 kind = "composite-control-plane"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/oximeter.tar.gz"
+path = "/work/package/install/crucible.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/ntp.tar.gz"
+path = "/work/package/install/external_dns.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/internal_dns.tar.gz"
+path = "/work/package/install/clickhouse_keeper.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
 path = "/work/package/install/cockroachdb.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/crucible.tar.gz"
+path = "/work/package/install/crucible_pantry.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/external_dns.tar.gz"
+path = "/work/package/install/oximeter.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/clickhouse_keeper.tar.gz"
+path = "/work/package/install/clickhouse.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/clickhouse.tar.gz"
+path = "/work/package/install/internal_dns.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
 path = "/work/package/install/probe.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/crucible_pantry.tar.gz"
+path = "/work/package/install/nexus.tar.gz"
 [[artifact.control_plane.source.zones]]
 kind = "file"
-path = "/work/package/install/nexus.tar.gz"
+path = "/work/package/install/ntp.tar.gz"
 [[artifact.host]]
 name = "host"
-version = "7.0.0-0.ci+git26fad698030"
+version = "7.0.0-0.ci+gitb4e1a285ef8"
 [artifact.host.source]
 kind = "file"
 path = "/input/host/work/helios/upload/os-host.tar.gz"
 [[artifact.trampoline]]
 name = "trampoline"
-version = "7.0.0-0.ci+git26fad698030"
+version = "7.0.0-0.ci+gitb4e1a285ef8"
 [artifact.trampoline.source]
 kind = "file"
 path = "/input/host/work/helios/upload/os-trampoline.tar.gz"

@jclulow
Copy link
Collaborator

jclulow commented Mar 25, 2024

FWIW, I've spent some time this weekend closing out oxidecomputer/buildomat#31. We now support HTTP range gets on files (see example testing with curl -C - in that ticket).

I've also finally figured out how to actually log what happens while transferring the body of a response, and implement log messages that include detailed information about the transfer (see oxidecomputer/buildomat#36). This should include information about whose fault we think an interruption is: did it happen on the downstream client side, or did it happen with the backend where we've stored the large file.

Could we try combining the split ZIP file into one slightly larger file in this PR? I haven't been able to reproduce the large file download issue myself lately, and we now have telemetry to investigate it if it recurs -- and it shouldn't be crippling, because curl -C - works for resuming the download and is easy to include in any scripts we have that download large files.

Copy link
Contributor

@labbott labbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm going to use this as a reference for the work I'm doing.

@iliana
Copy link
Contributor Author

iliana commented Mar 25, 2024

Could we try combining the split ZIP file into one slightly larger file in this PR?

I am tempted to hold off on this until we have the v7 release out the door, as to not break tooling that expects the parta/partb files while we're in a time crunch to get things on rack2/rack3. I am not sure how much of a concern this is in reality though. We could discuss in the dogfood channel?

@iliana
Copy link
Contributor Author

iliana commented Mar 25, 2024

Going to go ahead and merge this as-is, and write up a PR to stop doing the split post-v7.

@iliana iliana merged commit 0ad5b9a into main Mar 25, 2024
22 checks passed
@iliana iliana deleted the iliana/all-is-all branch March 25, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants