Single node clickhouse init #6903
Conversation
Uses new internal nexus API endpoints.
plotnick
force-pushed
the
single-node-clickhouse-init
branch
from
cf515bc
to
e725a76
Compare
plotnick
changed the base branch from
main
to
clickhouse-admin-smf-package-cleanup
| let admin_url = format!("http://{admin_addr}"); | ||
| let log = opctx.log.new(slog::o!("admin_url" => admin_url.clone())); | ||
| let client = ClickhouseSingleClient::new(&admin_url, log.clone()); | ||
| client.init_db().await.map(|_| ()).map_err(|e| { |
There was a problem hiding this comment.
It's unclear to me if this is the right place to try to do this initialization, since we'll presumably have just spun up the server. It might be better to wait until the single-node server appears in an inventory collection, like the multi-node server does. OTOH, it shouldn't take long to start an uninitialized database, so we might be able to get away with a small retry loop and some longish timeouts, which seems significantly simpler. Opinions welcome.
There was a problem hiding this comment.
You could ping the server and wait for that to succeed before trying this. The init_db() call also returns an error indicating the server isn't available, so you might be able to just retry this call itself. The SQL it applies is idempotent.
andrewjstone
force-pushed
the
clickhouse-admin-smf-package-cleanup
branch
from
63d3ba4
to
79713cb
Compare
Depends on #6894, replaces #6878, fixes #6826 on the server side.
Adds a new Dropshot server,
clickhouse-admin-single, analogous toclickhouse-admin-keeperandclickhouse-admin-server(which were split off fromclickhouse-adminin #6837). Its sole purpose is to initialize the single-node ClickHouse database with the current Oximeter schema. We use a single in-memory lock (atokio::sync::Mutex) to serialize initialization requests. Multi-node ClickHouse clusters will need something analogous as a follow-up.Still needs testing. My
a4x2cluster is currently being uncooperative, and so this has not been through a successful "spin-up, expunge ClickHouse, regenerate" cycle. Also missing unit tests.