Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multipart/form-data and file uploads #609

Closed
wants to merge 41 commits into from
Closed

Support multipart/form-data and file uploads #609

wants to merge 41 commits into from

Commits on Oct 19, 2023

  1. un-require unstable cargo fmt for now

    @ahirner
    ahirner committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9d8a789 View commit details
    Browse the repository at this point in the history

  2. enable reqwest's multipart

    @ahirner
    ahirner committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    95850e3 View commit details
    Browse the repository at this point in the history

  3. intro BodyContentType::FormData WIP

    @ahirner
    ahirner committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    92a32a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. impl files as Into<Body> WIP 

    * own OperationParamaterType
* delare replaced PartMeta
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    2ae53f7 View commit details
    Browse the repository at this point in the history

  2. switch binary string repr to some unit for now

    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    5bc61b0 View commit details
    Browse the repository at this point in the history

  3. introduce (optional) FormPart WIP 

    Todo:
* some work on cli
* some work on httpmock
* generate form in method body
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    31daaed View commit details
    Browse the repository at this point in the history

  4. cut and dry

    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    7ce4a0f View commit details
    Browse the repository at this point in the history

  5. generate form in method body WIP 

    except: create form from body
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    4298470 View commit details
    Browse the repository at this point in the history

  6. Revert "un-require unstable cargo fmt for now" 

    This reverts commit 9d8a789.
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0f71c90 View commit details
    Browse the repository at this point in the history

  7. EXPECTORATE=overwrite cargo test 

    adds:
use reqwest::multipart::Part;
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    e89338c View commit details
    Browse the repository at this point in the history

  8. fix Part body builder impls

    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    d614dff View commit details
    Browse the repository at this point in the history

  9. EXPECTORATE=overwrite cargo test 

    adds super::Part import
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    45f099a View commit details
    Browse the repository at this point in the history

  10. cleanup

    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    348a30f View commit details
    Browse the repository at this point in the history

  11. set params from form WIP 

    approach has two flaws:
* form params optional cannot be recovered from typify or ergonomically from schema
* fails for bodies with nested compound types, e.g. Map, Vec
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    4c2d2b9 View commit details
    Browse the repository at this point in the history

  12. serialize form data body as serde strings 

    the main benefit is correct treatment of
optionals and a baseline support for
nested compound parameters
    @ahirner
    ahirner committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    2a806f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge branch 'oxidecomputer:main' into feature/form_data

    @ahirner
    ahirner authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c8a9f31 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:ahirner/progenitor into feature/for… 

    …m_data
    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    38d34d2 View commit details
    Browse the repository at this point in the history

  3. add openapi-api sample schema 

    curl -L -o sample_openapi/openai-openapi.yaml https://raw.githubusercontent.com/openai/openai-openapi/84e9aa615dcb81c66d2d63b8d5dad025259223b2/openapi.yaml
    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    692b02a View commit details
    Browse the repository at this point in the history

  4. prune and describe openai-openapi.yaml 

    * removed endpoints not tagged with Images
* removed x-oaiMeta key
* inlined end_user_param_configuration

still gen fail: TypeError(InvalidValue)
    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    89b16ea View commit details
    Browse the repository at this point in the history

  5. uses_serde_json also depends on multipart/form-data bodies

    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6489729 View commit details
    Browse the repository at this point in the history

  6. no need to filter body_parts for existing types

    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    90f353d View commit details
    Browse the repository at this point in the history

  7. explicit type requirement err

    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6474706 View commit details
    Browse the repository at this point in the history

  8. verify_apis("openai-openapi.yaml") and EXPECTORATE=overwrite cargo test

    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c3ffd79 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/form_data' of github.com:ahirner/progenitor int… 

    …o feature/form_data
    @ahirner
    ahirner committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2521259 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. don't require (cli) form part WIP 

    reference types are emitted in modified and and modified
versions though
    @ahirner
    ahirner committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    aea0b0a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. fix quoting form data string values

    @ahirner
    ahirner committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    191105f View commit details
    Browse the repository at this point in the history

  2. fix to_form_string builder import

    @ahirner
    ahirner committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ba30bb1 View commit details
    Browse the repository at this point in the history

  3. factor out uses_request_file_part

    @ahirner
    ahirner committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    77ff7d2 View commit details
    Browse the repository at this point in the history

  4. let cli consumers override file request part

    @ahirner
    ahirner committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    716193f View commit details
    Browse the repository at this point in the history

  5. httpmock form data to a reasonable extent

    @ahirner
    ahirner committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    35ed72e View commit details
    Browse the repository at this point in the history

  6. blanket form data usage flag to remove unneeded .out diffs

    @ahirner
    ahirner committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    0ab9911 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. cargo clippy on new code

    @ahirner
    ahirner committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    91bea0b View commit details
    Browse the repository at this point in the history

  2. clarify use_form_parts comment

    @ahirner
    ahirner committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    fa31f6e View commit details
    Browse the repository at this point in the history

  3. move unreachable variant of method param last

    @ahirner
    ahirner committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    2c9cbdb View commit details
    Browse the repository at this point in the history

  4. document new OperationParameter variants

    @ahirner
    ahirner committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    829199c View commit details
    Browse the repository at this point in the history

  5. docstring for (still hidden) to_form_string

    @ahirner
    ahirner committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    5206425 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. TypeId based FormData bodies for text fields are still required 

    , thus no additional todo here
    @ahirner
    ahirner committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b4e916d View commit details
    Browse the repository at this point in the history

  2. nullable binary strings in form-data hardly make sense

    @ahirner
    ahirner committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    106205f View commit details
    Browse the repository at this point in the history

  3. no need for own dereferencing of schema objects 

    ReferenceOrExt already does everything we need, amazing
    @ahirner
    ahirner committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2a8e24a View commit details
    Browse the repository at this point in the history

  4. There is no need to treat binary strings at the type id level anymore 

    .. because a cloned and pruned body type is created separately.
We probalby want to get rid of redundant body structs iff. they
are referenced in multipart/form-data contents only
    @ahirner
    ahirner committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    9e204ed View commit details
    Browse the repository at this point in the history

  5. remove multipart/form-data structs from output if they are exclusivel… 

    …y referenced in such requests
    @ahirner
    ahirner committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f8baafa View commit details
    Browse the repository at this point in the history