fix(progenitor-macro): if 'client.inner' is not set by user do not provide it to user-specified functions. #933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding any hooks (
pre_async
,post
,pre
) you were implicitly required to add an empty type just to fill inclient.inner
property - even if you weren't actually using the client for anything. This mean that if you set an async hook without setting an inner client progenitor would create invalid code.We have changed that behaviour to only generate the
inner
parameter if it's actually set by the end user.Previous Code
After Change
Future Work
Given we have a token stream of the hook body, we could try to identify the parameters required and be a little smarter... but this is already a big improvement.