Return source of wrapped errors #943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Display` impl for `Error` wraps the original error received with a
message, e.g., "Communication error: {original_error_message}". The
`source` method returns the same error, though, so iterating over the
error chain will cause the same error message to be printed twice.
Update `source` to return the source error of the original error, not
our wrapper, to avoid this duplication.
|
I'm not sure I agree with this. Based on what we learned wouldn't it be more accurate to not print information about the source in the Display impl? |
|
Agreed, this is not the right approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Displayimpl forErrorwraps the original error received with a message, e.g., "Communication error: {original_error_message}". Thesourcemethod returns the same error, though, so iterating over the error chain will cause the same error message to be printed twice.Update
sourceto return the source error of the original error, not our wrapper, to avoid this duplication.