Use block_in_place for device pause/halt #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address cases where propolis-server was found to be wedged when the viona interrupt poller task happened to be assigned to the same tokio thread as the synchronous pause/halt action.
|
Took this branch for a spin - it fixed the wedge for me as well, thanks! |
hawkw
approved these changes
Jul 23, 2024
hawkw
reviewed
Jul 23, 2024
gjcolombo
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Not for this PR, but does it make sense to try to extend the work #716 to cover pause? (It seems like it might be more idiomatic to make pause return either "ok I'm paused" or the relevant future, rather than having callers call back into paused.)
Yeah, that seems like the way to go, IMO. |
|
Merged in 0a3a26b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address cases where propolis-server was found to be wedged when the viona interrupt poller task happened to be assigned to the same tokio thread as the synchronous pause/halt action.