Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken inline_quoted following _ #72

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benjaminleonard
Copy link
Collaborator

convertInlineQuoted breaks where _emphasised text_ follows other underscores, e.g. those in a URL.

This technically fixes this issue in this place (RFD 520) by moving closer to the HTML5 renderer implementation. But I believe this is a bug in asciidoctor (and the fix is a fluke) since node.getText() returns error_reports_faults_and_diagnosis_engines[Error reports], or _ereports rather than ereports.

image

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rfd-site ✅ Ready (Inspect) Visit Preview Oct 7, 2024 3:54pm

@benjaminleonard
Copy link
Collaborator Author

Will hold this, until I report on asciidoctor.

@benjaminleonard benjaminleonard marked this pull request as draft October 7, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant