Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite fields of struct field with tag child:"true" #638

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

goshansmails
Copy link
Collaborator

Fixes #636

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (67ecc39) to head (90c92c0).
Report is 17 commits behind head on master.

Files Patch % Lines
plugin/input/k8s/k8s.go 0.00% 9 Missing ⚠️
cfg/config.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage   70.83%   71.21%   +0.37%     
==========================================
  Files         124      131       +7     
  Lines       12572    13024     +452     
==========================================
+ Hits         8906     9275     +369     
- Misses       3150     3214      +64     
- Partials      516      535      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goshansmails goshansmails merged commit 91aed6b into master Jun 19, 2024
9 of 10 checks passed
@goshansmails goshansmails deleted the 636-remove-child-true branch June 19, 2024 14:48
goshansmails added a commit that referenced this pull request Jun 27, 2024
goshansmails added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: fix parsing config with tag child:"true"
3 participants