Feat/periodic check returns affected contracts #121
+374
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
requested changes
Jul 11, 2023
dlc-manager/src/manager.rs
Outdated
| fn check_signed_contract( | ||
| &mut self, | ||
| contract: &SignedContract, | ||
| ) -> Result<Option<ContractId>, Error> { |
There was a problem hiding this comment.
It feels like it'd be easier to just return a boolean here, indicating whether the contract was updated or not.
dlc-manager/src/manager.rs
Outdated
| @@ -2267,4 +2293,29 @@ mod test { | |||
| .on_dlc_message(&offer_message, pubkey()) | |||
| .expect_err("To reject the second offer message"); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
that's not a great test, I think it'd be better to add some checks in the integrations tests.
Tibo-lg
force-pushed
the
fix/fee-comtputation-issue
branch
2 times, most recently
from
2cd5f98
to
e9cf8e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.