Update ldk to v0.0.116 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw #135, not sure if these conflict? |
Merged
Tibo-lg
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Small concern with the threading in the electrs code, otherwise LGTM. Note that this does not address #119 though as #119 would be rebasing p2pderivatives/rust-lightning/split-tx-experiment on top of 0.0.116 and then making it work with the feature/ln-dlc-channels branch. But thanks still nice!
(and #135 is just update the version of the fork for the feature/ln-dlc-channels branch so no conflict there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade was pretty straight forward, only thing I am unsure of is if the way I handled the keys in sample/main.rs is backwards compatible.