Feature/ln dlc/handle ldk auto closing #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
force-pushed
the
feature/ln-dlc/handle-ldk-auto-closing
branch
6 times, most recently
from
2492275
to
0ed53a9
Compare
Tibo-lg
force-pushed
the
feature/ln-dlc/handle-ldk-auto-closing
branch
from
0ed53a9
to
f8716ae
Compare
luckysori
approved these changes
Aug 24, 2023
| @@ -24,7 +24,8 @@ impl_dlc_writeable!(SubChannel, { | |||
| (is_offer, writeable), | |||
| (own_fund_pk, writeable), | |||
| (counter_fund_pk, writeable), | |||
| (counter_party_secrets, writeable) | |||
| (counter_party_secrets, writeable), | |||
| (channel_keys_id, writeable) | |||
There was a problem hiding this comment.
Note to self: this breaks all pre-existing channels.
Tibo-lg
force-pushed
the
feature/ln-dlc/handle-ldk-auto-closing
branch
from
77c80d3
to
22af6ba
Compare
Tibo-lg
force-pushed
the
feature/ln-dlc/handle-ldk-auto-closing
branch
from
22af6ba
to
6ec92ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
SubChannelManagerto react to force closing events from LDK. To achieve this, a couple of things were needed:Not all states are properly covered for now as it's not clear how to get LDK to trigger force closes in some of the states.