Take care of review comments

pac4j · Jul 20, 2023 · 26f36d6 · 26f36d6
1 parent ca6580e
commit 26f36d6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 29 deletions.
diff --git a/src/main/java/org/pac4j/javalin/CallbackHandler.java b/src/main/java/org/pac4j/javalin/CallbackHandler.java
@@ -3,9 +3,8 @@
 import io.javalin.http.Context;
 import io.javalin.http.Handler;
 import org.jetbrains.annotations.NotNull;
+import org.pac4j.core.adapter.FrameworkAdapter;
 import org.pac4j.core.config.Config;
-import org.pac4j.core.engine.CallbackLogic;
-import org.pac4j.core.engine.DefaultCallbackLogic;
 import org.pac4j.jee.context.JEEFrameworkParameters;
 
 import static org.pac4j.core.util.CommonHelper.assertNotNull;
@@ -32,14 +31,9 @@ public CallbackHandler(Config config, String defaultUrl, Boolean renewSession) {
 
     @Override
     public void handle(@NotNull Context javalinCtx) {
-        final CallbackLogic callbackLogic;
-        if (config.getCallbackLogic() != null) {
-            callbackLogic = config.getCallbackLogic();
-        } else {
-            callbackLogic = DefaultCallbackLogic.INSTANCE;
-        }
-
-        callbackLogic.perform(
+        FrameworkAdapter.INSTANCE.applyDefaultSettingsIfUndefined(config);
+
+        config.getCallbackLogic().perform(
                 this.config,
                 this.defaultUrl,
                 this.renewSession,

diff --git a/src/main/java/org/pac4j/javalin/LogoutHandler.java b/src/main/java/org/pac4j/javalin/LogoutHandler.java
@@ -3,9 +3,8 @@
 import io.javalin.http.Context;
 import io.javalin.http.Handler;
 import org.jetbrains.annotations.NotNull;
+import org.pac4j.core.adapter.FrameworkAdapter;
 import org.pac4j.core.config.Config;
-import org.pac4j.core.engine.DefaultLogoutLogic;
-import org.pac4j.core.engine.LogoutLogic;
 import org.pac4j.jee.context.JEEFrameworkParameters;
 
 import static org.pac4j.core.util.CommonHelper.assertNotNull;
@@ -35,14 +34,9 @@ public LogoutHandler(Config config, String defaultUrl, String logoutUrlPattern)
 
     @Override
     public void handle(@NotNull Context javalinCtx) {
-        final LogoutLogic logoutLogic;
-        if (config.getLogoutLogic() == null) {
-            logoutLogic = DefaultLogoutLogic.INSTANCE;
-        } else {
-            logoutLogic = config.getLogoutLogic();
-        }
-
-        logoutLogic.perform(
+        FrameworkAdapter.INSTANCE.applyDefaultSettingsIfUndefined(config);
+
+        config.getLogoutLogic().perform(
             this.config,
             this.defaultUrl,
             this.logoutUrlPattern,

diff --git a/src/main/java/org/pac4j/javalin/SecurityHandler.java b/src/main/java/org/pac4j/javalin/SecurityHandler.java
@@ -4,9 +4,8 @@
 import io.javalin.http.Handler;
 import io.javalin.http.servlet.JavalinServletContext;
 import org.jetbrains.annotations.NotNull;
+import org.pac4j.core.adapter.FrameworkAdapter;
 import org.pac4j.core.config.Config;
-import org.pac4j.core.engine.DefaultSecurityLogic;
-import org.pac4j.core.engine.SecurityLogic;
 import org.pac4j.jee.context.JEEFrameworkParameters;
 
 import static org.pac4j.core.util.CommonHelper.assertNotNull;
@@ -37,14 +36,9 @@ public SecurityHandler(Config config, String clients, String authorizers, String
 
     @Override
     public void handle(@NotNull Context javalinCtx) {
-        final SecurityLogic securityLogic;
-        if (config.getSecurityLogic() == null) {
-            securityLogic = DefaultSecurityLogic.INSTANCE;
-        } else {
-            securityLogic = config.getSecurityLogic();
-        }
+        FrameworkAdapter.INSTANCE.applyDefaultSettingsIfUndefined(config);
 
-        Object result = securityLogic.perform(
+        Object result = config.getSecurityLogic().perform(
             this.config,
             (ctx, store, profiles) -> AUTH_GRANTED,
             this.clients,