fix(context): read disablePointerSelection from propsRef #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f0rr0
changed the title
f0rr0
changed the title
|
@pacocoursey would appreciate a few mins of your time on this. Many thanks |
pacocoursey
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
At present, updating the value
disablePointerSelectionprop after the component has rendered once does not propagate the updated value to the underlying code.contexthas outdated value ofdisablePointerSelectionsince the dependency array foruseMemois empty.Proposed Fix:
Similar to other places in current codebase, use the
propsRefwhich carries updated props instead of directly referencingdisablePointerSelectionprop.