Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): test Docker images in CI #430

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore(ci): test Docker images in CI #430

merged 1 commit into from
Jul 4, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jun 25, 2024

Maintainer Conveniences

  • Updates Dockerfile
    • Dockerfile was relevant for pact-go v1, now updated and tested as part of CI
  • Inability to use Docker in MacOS / Windows, means to run Pact Broker based tests, we need to use a hosted broker. This poses challenges for external contributors and the sharing of secrets, as using shared credentials in plain-text although convenient for our demo env, isn't best practise for actual end user use.
    • Provide a make pact_local command that skips publishing of pacts, and via setting SKIP_PUBLISH controls the provider verification test to either run a local or pact broker based verification. The publish code path is still covered by the linux runner. (there is probably a more elegant way of conditionally setting the values rather than a large if / else block

@coveralls
Copy link

Coverage Status

coverage: 29.152% (+0.1%) from 29.056%
when pulling 07ffd2d on deps/Dockerfile
into 4c2079f on master.

@coveralls
Copy link

Coverage Status

coverage: 29.152% (+0.1%) from 29.056%
when pulling 4125314 on deps/Dockerfile
into 4c2079f on master.

@YOU54F YOU54F requested a review from mefellows June 25, 2024 17:40
@YOU54F
Copy link
Member Author

YOU54F commented Jul 2, 2024

segfaults mentioned above resolved in #432

@YOU54F YOU54F force-pushed the deps/Dockerfile branch 2 times, most recently from 2dbc673 to 070604c Compare July 3, 2024 00:38
@coveralls
Copy link

Coverage Status

coverage: 29.252% (+0.1%) from 29.134%
when pulling 7fe738e on deps/Dockerfile
into c80e188 on master.

@coveralls
Copy link

Coverage Status

coverage: 29.365% (+0.2%) from 29.134%
when pulling e9056b2 on deps/Dockerfile
into c80e188 on master.

r := C.pactffi_using_plugin(m.pact.handle, cPluginName, cPluginVersion)
InstallSignalHandlers()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to install our signal handlers after starting our plugins. I wondered why we were still getting flakes after I had got it passing consistently first time before, and I went back and looked at my previous changes I'd tested and did a 😅

@coveralls
Copy link

Coverage Status

coverage: 29.376% (+0.2%) from 29.134%
when pulling a272944 on deps/Dockerfile
into c80e188 on master.

@YOU54F YOU54F changed the title chore(ci): test MacOS & Docker images in CI chore(ci): test Docker images in CI Jul 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 29.134%. remained the same
when pulling 1d0359a on deps/Dockerfile
into c80e188 on master.

@coveralls
Copy link

Coverage Status

coverage: 29.248%. remained the same
when pulling 5bbeb1a on deps/Dockerfile
into f3b61a7 on master.

@coveralls
Copy link

Coverage Status

coverage: 29.248%. remained the same
when pulling 19ca6ef on deps/Dockerfile
into f3b61a7 on master.

@coveralls
Copy link

Coverage Status

coverage: 29.248%. remained the same
when pulling fc2097e on deps/Dockerfile
into f3b61a7 on master.

@YOU54F YOU54F merged commit bd71f19 into master Jul 4, 2024
18 checks passed
@YOU54F YOU54F deleted the deps/Dockerfile branch July 4, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants