Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Cirrus CI environment #137

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: support Cirrus CI environment #137

merged 1 commit into from
Jul 10, 2023

Conversation

mefellows
Copy link
Member

YOU54F
YOU54F approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thanks Matt!

i think we may have the same issue on pull requests so they will still need the mapping in pact-js .cirrus.yml file.

it might be worth considering in the future, catering for detection of env vars only present in pull requests.

@mefellows
Copy link
Member Author

That's a good point too.

@YOU54F YOU54F merged commit d4ddde5 into master Jul 10, 2023
29 checks passed
@YOU54F YOU54F deleted the feat/support-cirrus-ci-environment branch July 10, 2023 10:42
@YOU54F YOU54F mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

@bethesque bethesque Awaiting requested review from bethesque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mefellows @YOU54F