Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verification-required command invalid arg number #152

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Nov 23, 2023

Trying out this command returned the following error

PACT_BROKER_FEATURES=verification_required pact-broker verification-required --pacticipant=FrontEndService --version foo

Error:-

/opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/pact_broker-client-1.74.0/lib/pact_broker/client/can_i_deploy.rb:22:in `call': wrong number of arguments (given 5, expected 3..4) (ArgumentError)
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/pact_broker-client-1.74.0/lib/pact_broker/client/cli/matrix_commands.rb:91:in `verification_required'
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor/command.rb:27:in `run'
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor/invocation.rb:127:in `invoke_command'
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor.rb:392:in `dispatch'
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor/base.rb:485:in `start'
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/vendor/ruby/3.2.0/gems/pact_broker-client-1.74.0/lib/pact_broker/client/cli/custom_thor.rb:34:in `start'
	from /opt/homebrew/Cellar/pact-ruby-standalone/2.0.9/lib/app/pact-broker.rb:34:in `<main>'

Removing the additional argument in the command, got it working

Returns exit code 1 - where no verification is required

Screenshot 2023-11-23 at 18 13 52

Returns exit code 0 - when verification is required

Screenshot 2023-11-23 at 18 14 41

Copy link
Member

@bethesque bethesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Champion.

@YOU54F YOU54F merged commit 4bd6a73 into master Dec 6, 2023
29 checks passed
@bethesque bethesque deleted the fix/verification_required_command branch December 7, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants