[QoL] Run History Function #1815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des merge conflict
merge from upstream main
[BETA] Read title from env files to allow for environment base changes
[Beta] pagefaultgames#2626 Pastel Veil & Sweet Veil
[Beta] pagefaultgames#2710 add semi invulnerable state check
…emon-switch Type move on pokemon switch
[Beta] pagefaultgames#2806 Localize terrain message
[BUG] - Beta - Mutlihit Moves + Messages not properly rendering on faint
…ncounters-beta [Beta] MEs dialogue token fix
Co-authored-by: flx-sta <[email protected]>
This was referenced Jul 6, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
This adds a new option on the menu for 'Run History'.
It allows users to store and look at a maximum of 25 past runs. This functionality automatically logs a run based on the current SessionSaveData and stores it in cache/the network database. At the moment, the function mirrors the 'Load Save' UI and only shows the team, whether they were victorious or not, the mode, wave, and the final timestamp of the run.
The server-side code is here: pagefaultgames/rogueserver#33
Why am I doing these changes?
This has been a feature requested by many users. In addition, this will allow the Balance and Development teams to do some analytics and have data on the gameplay experience.
I also have a bad memory so I thought it would be helpful to be able to access past runs to see what I need to do better.
What did change?
There are many changes:
Screenshots/Videos
Features
Languages
How to test the changes?
Q: How can a reviewer test your changes once they check out on your branch?
A: Play normally and log runs - successful or losses.
Q: Did you just make use of the
src/overrides.tsfile?A: Yes - but just to kill my Pokemon faster so I could log defeats.
Q: Did you introduce any automated tests?
A: No
Q: Does the reviewer need to do something special in order to test your change?
A: Yes - need to run RogueServer for network/database functionality
Checklist
npm run test)This still does not pass the Linter, but I plan on cleaning the PR up once all changes are made. My code is really messy, so I feel hesitant to remove all the imports.