Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix a couple of bugs regarding MEs and their localization #4261

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

CodeTappert
Copy link
Collaborator

@CodeTappert CodeTappert commented Sep 14, 2024

What are the changes the user will see?

  • Winstrate Names are localized
  • Titles of "myster challenger" named trainers are capitalized correctly
  • SURF and FLY Moves are correctly localized in the lost at sea ME

Why am I making these changes?

  • They were errors/not working as intended

What are the changes from a developer perspective?

  • I basically invoked i18next at 3 points in the code where it wasnt done
  • new function "setLocalizedName" to give named trainers that dont use a "initFor" method a way to have a localized name

Screenshots/Videos

  • TODO (Will do right after writiing this)

  • Lost at Sea BEFORE:
    image

  • Lost at Sea AFTER:
    image

  • Winstrates BEFORE:
    image

  • Winstrates AFTER:
    image

  • Named Trainer Title Mystery Challenger BEFORE:
    image

  • Named Trainer Title Mystery Challenger AFTER:
    image

How to test the changes?

Thats the tricky part...You basically need the localization files to test it...
So merge #4183 locally. And test for example in german (which is completly translated)

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

Fixed Mysterious Challenger Title not beeing correct
Fixed Winstrate Names not beeing localized
…e all named trainers that dont use a "initFor" method)
@CodeTappert CodeTappert requested a review from a team as a code owner September 14, 2024 20:45
Adri1
Adri1 previously approved these changes Sep 14, 2024
SangaraSorama
SangaraSorama previously approved these changes Sep 14, 2024
@Tempo-anon Tempo-anon merged commit aecdcd3 into pagefaultgames:beta Sep 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants