[Bug] Fix for "Moves Can Miss Against Protect, Baneful Bunker, King's Shield"

[PrabbyDD]

What are the changes the user will see?

Fixing #4060, so if pokemon misses against a move that protects, it will properly protect against the move despite missing
After effects of a protected, missed attack do t trigger if the move is contact (tested with slash)
After effects of a protected, missed attack do not trigger if the move is non contact (tested with flash cannon)

Why am I making these changes?

To fix #4060

What are the changes from a developer perspective?

Moved protect check to be before hit check, and avoid hitcheck if the pokemon is protected

Screenshots/Videos

2024-09-14.13-19-17.mp4

2024-09-14.13-19-32.mp4

2024-09-14.13-20-17.mp4

2024-09-14.13-20-32.mp4

2024-09-14.13-45-09.mp4

How to test the changes?

Use npm run test, as well as changing override files to test moves, and manually go into move-effect-phase.ts and change return value of hitCheck() to be false.

npm test obstruct (modified)
npm test baneful_bunker (added)

Run these two tests as specifically. I also tested manually via removing the forceMiss() function, and changing hitCheck() to return false to be sure.

I would appreciate any feedback on the changes to the move-effect-phase.ts file. Not really a good way to test protect specifically, since it doesnt have after effects.

I tested manually with other moves as well, like King's Shield and Burning Bulwark. Seems to work fine for all now.

Checklist

• I'm using beta as my base branch
• [x ] There is no overlap with another PR?
• [ x] The PR is self-contained and cannot be split into smaller PRs?
• [ x] Have I provided a clear explanation of the changes?
• [ x] Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• [ x] Have I tested the changes (manually)?
  • [x ] Are all unit tests still passing? (npm run test)
• [ x] Are the changes visual?
  • [ x] Have I provided screenshots/videos of the changes?

[innerthunder]

The source code seems good; just some nits on the test code