[Qol] Make i18n money formatter controlled by translators #4550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
pagefaultgames/pokerogue-locales#6
What are the changes the user will see?
n/a
Why am I making these changes?
Right now the money-formatter is hard-coded per language.
This should not be the case but instead be controlled by the translators in the locales directory
What are the changes from a developer perspective?
The i18n money formatter now calls a new key
common:money
to display the money correctly.Note
Updates the locales submodule to pagefaultgames/pokerogue-locales@56eeb80
Screenshots/Videos
see pagefaultgames/pokerogue-locales#6
How to test the changes?
Checklist
beta
as my base branch[ ] Have I considered writing automated tests for the issue?npm run test
)