Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qol] Make i18n money formatter controlled by translators #4550

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

flx-sta
Copy link
Collaborator

@flx-sta flx-sta commented Oct 2, 2024

What are the changes the user will see?

n/a

Why am I making these changes?

Right now the money-formatter is hard-coded per language.
This should not be the case but instead be controlled by the translators in the locales directory

What are the changes from a developer perspective?

The i18n money formatter now calls a new key common:money to display the money correctly.

Note

Updates the locales submodule to pagefaultgames/pokerogue-locales@56eeb80

Screenshots/Videos

see pagefaultgames/pokerogue-locales#6

How to test the changes?

  1. make sure to check out the locales repo branch
  2. Start
  3. Activate something where you can see the money formatter (e.g. FUn & Games ME)
  4. Check the visuals

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@flx-sta flx-sta added Enhancement New feature or request Localization Provides or updates translation efforts Refactor Rewriting existing code related and removed Enhancement New feature or request labels Oct 2, 2024
@flx-sta flx-sta marked this pull request as ready for review October 2, 2024 19:54
@flx-sta flx-sta requested a review from a team as a code owner October 2, 2024 19:54
CodeTappert
CodeTappert previously approved these changes Oct 2, 2024
@flx-sta flx-sta requested a review from Adri1 October 4, 2024 18:33
Adri1
Adri1 previously approved these changes Oct 5, 2024
update reference to `56eeb809eb5a2de40cfc5bc6128a78bef14deea9` (from `3ccef8472dd7cc7c362538489954cb8fdad27e5f`)
@flx-sta flx-sta dismissed stale reviews from Adri1 and CodeTappert via e653923 October 5, 2024 00:40
@CodeTappert CodeTappert merged commit 42b75e8 into pagefaultgames:beta Oct 5, 2024
14 checks passed
@flx-sta flx-sta deleted the qol/locales-cleanup branch October 5, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts Refactor Rewriting existing code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants