-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qol] Load i18n en locales during tests #4553
[Qol] Load i18n en locales during tests #4553
Conversation
the backend is being supported by using msw which will import the correct file from the local locales folder
src/test/mystery-encounter/encounters/teleporting-hijinks-encounter.test.ts
Outdated
Show resolved
Hide resolved
src/test/mystery-encounter/encounters/teleporting-hijinks-encounter.test.ts
Outdated
Show resolved
Hide resolved
…unter.test.ts Co-authored-by: NightKev <[email protected]>
…unter.test.ts Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
src/test/mystery-encounter/encounters/a-trainers-test-encounter.test.ts
Outdated
Show resolved
Hide resolved
…r.test.ts Co-authored-by: MokaStitcher <[email protected]>
Not really. It's the nature of allowing requests to be sent and having to wait for them.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few typos, would love to see more description on the PR, otherwise looks good
Co-authored-by: Adrian T. <[email protected]>
src/test/mystery-encounter/encounters/field-trip-encounter.test.ts
Outdated
Show resolved
Hide resolved
update reference to `56eeb809eb5a2de40cfc5bc6128a78bef14deea9` (from `3ccef8472dd7cc7c362538489954cb8fdad27e5f`)
Why am I making these changes?
Right now it's kinda hard to read the obfuscated logs during tests as it's just i18n keys.
What are the changes from a developer perspective?
Screenshots/Videos
N/A
How to test the changes?
Run the tests. YOu should see human readable english output yet fully functional tests.
Checklist
beta
as my base branch[ ] Have I considered writing automated tests for the issue?[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)[] Are the changes visual?