Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] Improve typing in phaseInterceptor.ts #4560

Merged
merged 8 commits into from
Oct 10, 2024
Merged

[Dev] Improve typing in phaseInterceptor.ts #4560

merged 8 commits into from
Oct 10, 2024

Conversation

torranx
Copy link
Collaborator

@torranx torranx commented Oct 3, 2024 •
edited
Loading

What are the changes the user will see?

none

Why am I making these changes?

more typing === better dev experience

What are the changes from a developer perspective?

  • added new types: PhaseClass, PhaseString, and PhaseInterceptorPhase
  • updated erroneous docs

Screenshots/Videos

Screenshot 2024-10-04 at 1 56 58 AM

How to test the changes?

your IDE should not be shouting at you

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@torranx torranx requested a review from a team as a code owner October 3, 2024 17:57
flx-sta
flx-sta reviewed Oct 3, 2024
View reviewed changes
src/test/utils/phaseInterceptor.ts Outdated Show resolved Hide resolved
src/test/utils/phaseInterceptor.ts Outdated Show resolved Hide resolved
src/test/utils/phaseInterceptor.ts Outdated Show resolved Hide resolved
@Tempo-anon Tempo-anon added the Refactor Rewriting existing code related label Oct 3, 2024
@torranx torranx requested a review from flx-sta October 3, 2024 20:20
@DayKev DayKev added the Tests Automated tests related label Oct 4, 2024
@DayKev DayKev changed the title [Dev] Improve typing in phaseInterceptor.ts [Dev] Improve typing in phaseInterceptor.ts Oct 4, 2024
@torranx torranx closed this Oct 4, 2024
@torranx torranx deleted the dev/phaseInterceptor-cleanup branch October 4, 2024 18:06
@torranx torranx restored the dev/phaseInterceptor-cleanup branch October 4, 2024 18:18
@torranx torranx reopened this Oct 4, 2024
@Tempo-anon Tempo-anon merged commit 0996789 into pagefaultgames:beta Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DayKev DayKev DayKev approved these changes

@MokaStitcher MokaStitcher Awaiting requested review from MokaStitcher MokaStitcher is a code owner automatically assigned from pagefaultgames/junior-dev-team

@Tempo-anon Tempo-anon Awaiting requested review from Tempo-anon Tempo-anon is a code owner automatically assigned from pagefaultgames/junior-dev-team

@flx-sta flx-sta Awaiting requested review from flx-sta

Assignees
No one assigned
Labels
Refactor Rewriting existing code related Tests Automated tests related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torranx @DayKev @flx-sta @Tempo-anon