-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Pokerogue API client #4583
[Refactor] Pokerogue API client #4583
Conversation
this is not a permanent solution
These are now unused after the refactor, should we delete them or mark them as Lines 273 to 276 in 684fb93
|
|
The Discord and Google unlink requests should be partially testable by linking using the admin panel, then unlinking using the admin panel or by using Menu > Manage Data > Unlink. |
I've done some testing and haven't found any issues so far |
Co-authored-by: PigeonBar <[email protected]>
src/test/mystery-encounter/encounters/clowning-around-encounter.test.ts
Outdated
Show resolved
Hide resolved
@PigeonBar Applied all your suggested changes. |
What are the changes the user will see?
n/a
Why am I making these changes?
Well you know how it is... the way it was designed in the code was bugging @Opaque02 & me. I thought I fast and easy fix it. One thing leads to another and here we are..
Warning
I couldn't check the discord/google unlink requests due to local limitations.
Yes, I did set up my own Discord Dev Application to link it to but it simply refused to save those discord IDs into the database. No idea why
What are the changes from a developer perspective?
All
Utils.apiFetch
andUtils.apiPost
were replaced with a newPokerogueApi
class which is structured into sub-apisEvery request & response from the API is properly typed now
Screenshots/Videos
n/a
How to test the changes?
VITE_BYPASS_LOGIN
to0
inenv.development
Checklist
beta
as my base branchnpm run test
)[] Are the changes visual?