[Beta][P1] Fix regression in Metal Burst caused by #3974 #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a regression test for the scenario
DayKev
added
Move
|
Related issue: #4575 |
ben-lear
approved these changes
Oct 6, 2024
Snailman11
added
the
Beta
flx-sta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Metal Burst will not crash if the target faints before the user moves.
Why am I making these changes?
Regression caused by #3974
What are the changes from a developer perspective?
The code that accidentally got reverted is put back in, plus tests were added for Metal Burst.
Screenshots/Videos
For video example of the crash, see #4576
How to test the changes?
npm run test metal_burstChecklist
betaas my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?