Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2 Bug] Fix Own Tempo Rockruff not being able to evolve #4762

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

PigeonBar
Copy link
Collaborator

What are the changes the user will see?

Own Tempo Rockruff will be able to evolve into Dusk Lycanroc.

Why am I making these changes?

Fixing a bug.

What are the changes from a developer perspective?

Own Tempo Rockruff's evolution condition now checks for the Rockruff to have form key "own-tempo" instead of "". (This has been broken for a while but did not matter until #4581.)

Screenshots/Videos

Before the changes: Own Tempo Rockruff cannot evolve
20241029.Rockruff.No.Evo.mp4
After the changes: Own Tempo Rockruff evolves properly
20241029.Rockruff.Dusk.Evo.mp4
After the changes: Regular Rockruff evolves properly
20241029.Rockruff.Midnight.Evo.mp4

How to test the changes?

All of Rockruff's evolutions occur level 25.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@PigeonBar PigeonBar requested a review from a team as a code owner October 30, 2024 01:35
@Madmadness65 Madmadness65 added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Oct 30, 2024
@Tempo-anon Tempo-anon merged commit 5b9dfe1 into pagefaultgames:beta Oct 30, 2024
13 checks passed
@PigeonBar PigeonBar deleted the fix-rockruff-evo branch October 30, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants