-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Add overrides for alternating between single and double battles #4833
[Dev] Add overrides for alternating between single and double battles #4833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't playtested but code lgtm
This comment was marked as outdated.
This comment was marked as outdated.
TBH, I still prefer EDIT: if we decide to keep the |
Since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, would love to see another pr that changes the battyleType
override to battleStyle
for consistency
What are the changes the user will see?
BATTLE_TYPE_OVERRIDE: "even-doubles",
- Double battles on even-numbered waves, single battles on odd-numbered waves.BATTLE_TYPE_OVERRIDE: "odd-doubles",
- Double battles on odd-numbered waves, single battles on even-numbered waves.Ideally, no changes if not using overrides.
Why am I making these changes?
This will help with testing transitions between single and double battles. For example, it will help with testing the newly implemented Commander (#4670).
(I am adding both "even-doubles" and "odd-doubles" so that, for example, we can force a X0 -> X1 biome change to be either a singles -> doubles or doubles -> singles transition.)
What are the changes from a developer perspective?
Screenshots/Videos
even-doubles
20241109.Even.Doubles.mp4
odd-doubles
20241109.Odd.Doubles.mp4
How to test the changes?
Use the above overrides in
overrides.ts
.npm run test double_battle.test.ts
Checklist
beta
as my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)[ ] Are the changes visual?