Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite] Implement female icon assets #4841

Merged
merged 6 commits into from
Nov 10, 2024

Conversation

chaosgrimmon
Copy link
Collaborator

What are the changes the user will see?

Certain Pokemon with significant gender differences will now have those changes reflected in their icons.

Why am I making these changes?

Should've been done when those variants were implemented.

What are the changes from a developer perspective?

Added some more lines to the list of female icons in pokemon-species.ts. As a result, had to add the now-expected female icons to the affected non-variant iconsheets. (The female variant icons had been updated in the last variant cycle.)
To futureproof, those female icons were also added to the folders of icons used to compile iconsheets. (Doduo and Dodrio's female non-variant icons were already in the Gen1 folder.)

Screenshots/Videos

Before

image

After

image
image

image

image

image
image

How to test the changes?

Use overrides to generate the relevant Pokemon.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
    - [] Have I considered writing automated tests for the issue?
    - [] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@chaosgrimmon chaosgrimmon requested a review from a team as a code owner November 10, 2024 19:20
@chaosgrimmon chaosgrimmon added Sprite/Animation For when graphics are incorrect P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Nov 10, 2024
@Tempo-anon Tempo-anon merged commit f2a2281 into pagefaultgames:beta Nov 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. Sprite/Animation For when graphics are incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants