[Sprite] Implement female icon assets #4841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Certain Pokemon with significant gender differences will now have those changes reflected in their icons.
Why am I making these changes?
Should've been done when those variants were implemented.
What are the changes from a developer perspective?
Added some more lines to the list of female icons in
pokemon-species.ts
. As a result, had to add the now-expected female icons to the affected non-variant iconsheets. (The female variant icons had been updated in the last variant cycle.)To futureproof, those female icons were also added to the folders of icons used to compile iconsheets. (Doduo and Dodrio's female non-variant icons were already in the Gen1 folder.)
Screenshots/Videos
Before
After
How to test the changes?
Use overrides to generate the relevant Pokemon.
Checklist
beta
as my base branch- [] Have I considered writing automated tests for the issue?- [] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)