Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Modernize the tests for the Zen Mode ability #4845

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Nov 11, 2024

What are the changes the user will see?

N/A

Why am I making these changes?

The test file is very outdated/questionable.

What are the changes from a developer perspective?

The Zen Mode tests are more comprehensible (and more accurate?).

How to test the changes?

npm run test zen_mode

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • [ ] Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

@DayKev DayKev added Tests Automated tests related Refactor Rewriting existing code related labels Nov 11, 2024
@DayKev DayKev requested a review from a team as a code owner November 11, 2024 04:51
@Tempo-anon Tempo-anon merged commit 6799594 into pagefaultgames:beta Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Rewriting existing code related Tests Automated tests related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants