Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta][Misc] Improved cursor memory for target selection in Doubles #4849

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

frutescens
Copy link
Collaborator

What are the changes the user will see?

The cursor will reset its position to the leftmost enemy when:

  1. It is the first turn (of the wave) for the Pokemon involved.
  2. A new wave begins
  3. The Pokemon used a move that targeted an ally or itself
    It will remember its position if it targets an enemy though.

Why am I making these changes?

Changes requested by Beta testers.

What are the changes from a developer perspective?

Changes to show() and processInput()

Screenshots/Videos

freecompress-Screen.Recording.2024-11-11.at.1.58.10.PM.mp4

How to test the changes?

  1. Fight in a double battle and check how the user facing conditions are working.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@frutescens frutescens added Miscellaneous Changes that don't fit under any other label Beta Only present on Beta (didn't make it into production [yet]) labels Nov 11, 2024
@frutescens frutescens requested a review from a team as a code owner November 11, 2024 22:02
src/ui/target-select-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/target-select-ui-handler.ts Outdated Show resolved Hide resolved
@Tempo-anon Tempo-anon merged commit c535e92 into pagefaultgames:beta Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Only present on Beta (didn't make it into production [yet]) Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants