Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Set the IVs of default starters to 15 #4861

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

frutescens
Copy link
Collaborator

What are the changes the user will see?

The default starters will all start with IVs of 15. In addition, Fresh Start Challenge will also respect this change and starters will have IVs of 15.

Why am I making these changes?

Balance Team request.

What are the changes from a developer perspective?

game-data.ts and challenges.ts edited for this change.

Screenshots/Videos

Screen_Recording_2024-11-13_at_12.32.06_PM.mov

How to test the changes?

  1. Start a new save file + Look at the IVs of the starters in starter-selection
  2. Start a Fresh Start run -> IVs of the starters should be all set to 15

Checklist

  • I'm using beta as my base branch
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@frutescens frutescens requested a review from a team as a code owner November 13, 2024 20:39
@frutescens frutescens added the Game Balance Changes focused on game balance label Nov 13, 2024
Copy link
Collaborator

@DayKev DayKev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add some sort of save migration later as well.

@Tempo-anon
Copy link
Collaborator

What happens if you use a save file with IVs under 15?

@DayKev
Copy link
Collaborator

DayKev commented Nov 13, 2024

What happens if you use a save file with IVs under 15?

It shouldn't do anything at all, if initDexData() overwrote existing saves then no one would be able to get better IVs/etc for their starters.

@Tempo-anon
Copy link
Collaborator

Seems just a little weird that older accounts will technically have a bit worse IVs for some mons vs newer accounts but 🤷

@frutescens
Copy link
Collaborator Author

Seems just a little weird that older accounts will technically have a bit worse IVs for some mons vs newer accounts but 🤷

@Tempo-anon closer to the update, I'll make sure to include it in any save conversion + write a save converter myself.

@frutescens frutescens merged commit d0d9eb7 into pagefaultgames:beta Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game Balance Changes focused on game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants