-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Balance] No more double 50x bosses in Endless + cleaning up RNG #4862
Merged
innerthunder
merged 9 commits into
pagefaultgames:beta
from
frutescens:endlessDoubleBossBattle
Nov 15, 2024
Merged
[Balance] No more double 50x bosses in Endless + cleaning up RNG #4862
innerthunder
merged 9 commits into
pagefaultgames:beta
from
frutescens:endlessDoubleBossBattle
Nov 15, 2024
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out there's an old bug with the Lines 238 to 241 in 0c521bb
|
Partially fixes #4527 for endure tokens. |
DayKev
reviewed
Nov 14, 2024
frutescens
changed the title
[Balance] No more double 50x bosses in Endless + cleaning up Endure token RNG
[Balance] No more double 50x bosses in Endless + cleaning up RNG
Nov 14, 2024
MokaStitcher
approved these changes
Nov 14, 2024
DayKev
approved these changes
Nov 15, 2024
innerthunder
approved these changes
Nov 15, 2024
damocleas
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Wave 50x bosses will no longer be encountered as double battles.
Little to no impact on Endure Tokens + Thief/Covet however.
Why am I making these changes?
Balance request.
What are the changes from a developer perspective?
New conditional added to battle-scene.ts that cancels out a double battle if it is a wave 50x boss battle.
Endure Token RNG brought into standard format with the rest of the game. It no longer relies on percentages (0.02 -> 2) and RandSeedInt(100) is used to determine the target's endure chance instead. This ensures that the Endure token is tied to the current battle's seed, not the overall run's seed. Also brought in Thief/Covet chance rolls to be in line with the game too.
How to test the changes?
Checklist
beta
as my base branchnpm run test
)