Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Remove from trainers: Pika/Eevee forms before 30, BB Gren, Rival starter HA #4863

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Fontbane
Copy link
Contributor

@Fontbane Fontbane commented Nov 14, 2024

What are the changes the user will see?

  • Trainers can no longer spawn with alternate forms (Partner, Cosplay, etc) of Pikachu or Eevee before wave 30
  • Trainers can no longer have Battle Bond Greninja
  • Rival's starter can no longer have its Hidden Ability

Why am I making these changes?

  • Too many people getting curbstomped by Preschoolers with partner Eevee
  • Hard to balance trainers with Greninja when it has a 1/2 chance of having a mega
  • Rival difficulty can vary wildly if their starter has hidden ability

What are the changes from a developer perspective?

  • Checks if it's a trainer battle before deciding forms for Pikachu, Eevee and Greninja
  • Adds p => p.abilityIndex = 0 postProcess to rival starter configs

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Fontbane Fontbane requested a review from a team as a code owner November 14, 2024 00:41
@Fontbane Fontbane changed the title [Balance] Remove Pika/Eevee forms from Trainers before wave 30, also BB Gren [Balance] Remove Pika/Eevee forms from Trainers before wave 30, BB Gren from all trainers Nov 14, 2024
DayKev
DayKev previously approved these changes Nov 14, 2024
DayKev
DayKev previously approved these changes Nov 14, 2024
src/battle-scene.ts Outdated Show resolved Hide resolved
@Fontbane Fontbane changed the title [Balance] Remove Pika/Eevee forms from Trainers before wave 30, BB Gren from all trainers [Balance] Remove from trainers: Pika/Eevee forms before 30, BB Gren, Rival starter HA Nov 14, 2024
@Tempo-anon Tempo-anon merged commit ef7d860 into pagefaultgames:beta Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants