Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Fix Liquidation, Double Edge, Body Press TM compatibility #4879

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

  • Fixes compatibility for Liquidation, Double Edge, and Body Press TMs
  • Double Edge was a near-universal tutor move in Gen 3, so the extra Double Edge compatibilities are from there
  • Many of the Liquidation ones are pre-evolutions

Why am I making these changes?

  • They were wrong

What are the changes from a developer perspective?

  • Esca listed the Double Edge changes here (note: the confusion on Deoxys at the end is due to Normal forme only existing in RS, where there are no move tutors)
  • Liquidation:
    • Squirtle, Wartortle
    • Tentacool, Tentacruel
    • Totodile, Croconaw
    • Chinchou, Lanturn
    • Lugia
    • Mudkip, Marshtomp
    • Latias, Latios
  • Body Press:
    • Rhyhorn
    • Meganium
    • Bastiodon
    • Rampardos
    • Emboar
    • Cobalion

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Fontbane Fontbane requested a review from a team as a code owner November 15, 2024 18:56
@damocleas damocleas added the Balance Team Specifically a balance team change label Nov 15, 2024
@Tempo-anon Tempo-anon merged commit 5e7d44a into pagefaultgames:beta Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants