Implement get_letter_grade and shortest_string #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybobo
reviewed
Jun 8, 2018
|
|
||
| #Put your code here! | ||
| grade = '' | ||
| case integer |
There was a problem hiding this comment.
the case statement returns whatever the result of whatever meets the condition so no need to use the grade variable anywhere within this function.
see: https://ruby-doc.org/docs/keywords/1.9/Object.html#method-i-case
|
|
||
| return grade |
There was a problem hiding this comment.
ruby functions will return the last evaluated expression so explicit returns aren't used often except in the case of guard clauses.
example where someone might use an explicit return.
def is_tall?(person)
return false if person.short?
true
end
| end | ||
|
|
||
| def shortest_string(array) | ||
|
|
||
| #Put your code here! | ||
| sorted_array = array.sort_by { |word| word.length } |
There was a problem hiding this comment.
this can also be written a bit more tersely but still readable. see: https://ruby-doc.org/core-2.5.1/Enumerable.html#method-i-min_by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.