successfully completed #108
Conversation
| "F" | ||
| else | ||
| "Invalid Input" | ||
| end |
There was a problem hiding this comment.
Nice, clean solution.
Tackling the invalid inputs is an extra step, but let's talk about the best way to do that. This might be a good case for using a guard clause up front - something like return 'Invalid Input' unless integer.is_a? Integer. But that gets me thinking about what the desired behavior would actually be here. Obviously, this all depends on what sort of broader program this method would appear in, but my hunch is that in most use cases, either returning nil or raising a TypeError would be more helpful than returning a different string.
letsdrill.rb
Outdated
|
|
||
| #Put your code here! | ||
|
|
||
| array.sort_by {|string| string.length}[0] |
There was a problem hiding this comment.
Nice. Ruby has first, so that is typically preferred to [0] for stylistic reasons. But also, scan through the ruby Enumerable documentation, and see if you can't find a method that is even more fitting than what you have here.
Thanks for the review!