Fixed incorrect operator precedence #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, if __optr is == or !=, the if condition on line 1052
is unintendedly interpreted as
((real_t)(opndv1.data.integer __optr opndv2.data.integer) == (real_t)opndv1.data.integer)
__optr
(real_t)opndv2.data.integer
because the associativity of != and == operators in C is left-to-right.
Fixed by fully parenthesize the complex comparison expression.
paladin-t
added a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if
__optris==or!=, the if condition on line 1052 is unintendedly interpreted asbecause the associativity of
!=and==operators in C is left-to-right. Fixed by fully parenthesize the complex comparison expression.