Add preview argument #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgearty
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Thanks @LewisAJones! I noticed this approach didn't work if you didn't have anything plotted already, so I've modified the code slightly to work in that case as well. I could actually envision this code I added also being a standalone function for users to preview individual phylopics, but I'm not sure if users would be doing that outside of this function, so we can just leave it here for now. Give it a glance and merge if you are happy with it!
|
Looks good to me! Thanks for the fix! I don't see why we need the extra standalone preview function as this would be presumably be using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a preview argument to
get_phylopic.Currently, I've implemented this using
add_phylopic_base. I don't see why we need to repeat a bunch of code for handling different formats when we already have it here. What do you think?Closes #59.