add text argument #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
willgearty
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Just a few minor requests, then it's good to go. Thanks @LewisAJones!
|
Hi @willgearty, I've implemented your suggestions! The |
|
Whoops, you forgot to move knitr from suggests to imports @LewisAJones! |
|
Fixed! I'll merge once the checks pass, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
textargument toget_attribution. This allows the user to return a text paragraph of the attribution information to insert directly into a figure caption or similar.I am not particularly happy with the approach for getting the license information. I originally thought I could just pull this from the PhyloPic API but when testing this, it doesn’t seem to return all the different licenses. Therefore, this is hardcoded for now, but could be updated!
These updates also now allow
get_attributionto be called with multiple uuids at once.Closes #56.