Allow for user to specify outline color #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LewisAJones
requested changes
Aug 21, 2023
There was a problem hiding this comment.
Hey @willgearty, this is looking great! Nothing really to comment on the code... behaves as it should. I've suggested a few changes to documentation. My main comment is that I think we should try to ensure the same behaviour between add_phylopic, add_phylopic_base, and geom_phylopic for the color and fill arguments.
Co-authored-by: Lewis A. Jones <[email protected]>
|
Thanks for the review @LewisAJones! I believe that should address all of your comments. I've changed the default behavior, and this behavior is now the same across all three functions. |
LewisAJones
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Thanks @willgearty! Changes look good to me now, I have nothing worthwhile adding. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
fillargument/aesthetic that allows users to specify different outline and body colors for silhouettes (ingeom_phylopic,add_phylopic, andadd_phylopic_base):Note that I was able to make it such that if only the
coloraesthetic/argument was specified (the old user behavior) in geom_phylopic or add_phylopic that that color is used for both the color and fill now.Fixes #58.