Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for OpenJDK Early Access builds #423

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

bjlaub
Copy link

@bjlaub bjlaub commented Sep 24, 2024

Before this PR

Only Zulu, Corretto, and Graal CE are supported

After this PR

==COMMIT_MSG==
add support for OpenJDK Early Access builds
==COMMIT_MSG==

Possible downsides?

Early Access builds should really only be used for experimentation at the moment. However it may be generally advantageous to have this pattern available for future EA builds from OpenJDK projects (e.g. Valhalla or any as-yet-unreleased OpenJDK build, which could be used for prototyping before features land in a full JDK release).

@changelog-app
Copy link

changelog-app bot commented Sep 24, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

add support for Project Loom JDK24 Early Access builds

Check the box to generate changelog(s)

  • Generate changelog entry

crogoz
crogoz previously approved these changes Sep 25, 2024
@policy-bot policy-bot bot dismissed crogoz’s stale review September 25, 2024 16:48

Invalidated by push of 079a9a0

@bjlaub
Copy link
Author

bjlaub commented Sep 25, 2024

i think this might still need some tweaking to allow the base URL to be correctly overridden in certain scenarios

@@ -24,7 +24,8 @@
public enum JdkDistributionName {
AZUL_ZULU,
AMAZON_CORRETTO,
GRAALVM_CE;
GRAALVM_CE,
LOOM_EA;
Copy link
Contributor

@CRogers CRogers Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than loom EA specifically, can we just have one for all OpenJDK EAs (and have loom in the version string?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is in the version string? 24-loom+7-60

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think I can make this work. The URLs are ever so slightly different for e.g. JDK24 EA builds versus project-specific builds, but I think we can work around that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CRogers i think e0fb0db should do the trick

@bjlaub bjlaub changed the title add support for Project Loom JDK24 Early Access builds add support for OpenJDK Early Access builds Sep 27, 2024
carterkozak
carterkozak previously approved these changes Sep 27, 2024
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with DNM to unblock a release candidate

carterkozak
carterkozak previously approved these changes Sep 27, 2024
@policy-bot policy-bot bot dismissed carterkozak’s stale review September 27, 2024 19:17

Invalidated by push of 2c42aef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants