Added linebreak option for indent filter.

[mjeromin]

This change fixes the indent filter so that it can support any line break sequence, including line feed (LF), carriage return line feed (CRLF), and carriage return (CR), whichever newline sequence is set in the environment.

#2016

fixes #2016

👋 This is my first time contributing, please advise if an entry to CHANGES.rst should be added and which version it should be associated (e.g. 3.2.0).

[davidism]

The issue points out that the environment already has a setting for the line ending. That should be used instead of adding a filter argument.

[jmbraben]

As stated in #2016 , the changes addressed my use case. Was any search for any other instances of hardcoded use of '\n' made?

[davidism]

Was any search for any other instances of hardcoded use of '\n' made?

I don't think so. If you (or someone else) want to look, and find other places that should use the env setting, that would be another good issue to open.

[jmbraben]

There is nothing else in filters.py, the only thing in /src I'm questioning is:

jinja/src/jinja2/compiler.py

Line 457 in ada0a9a

self.stream.write("\n" * self._new_lines)

But as in the compiler.py, thinking it is not an issue.

[davidism]

You're right, that's not an issue.

[jmbraben]

@mjeromin Is there any timeline to merge this?

[mjeromin]

@jmbraben We confirmed the fix in the issue #2016, we can go ahead and merge. Thanks!