-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent password reset brute force #778
Open
geozak
wants to merge
7
commits into
panique:master
Choose a base branch
from
geozak:prevent-password-reset-brute-force
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 8, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 60a9eed - Browse repository at this point
Copy the full SHA 60a9eedView commit details -
Added messages to support changes in verifyPasswordReset
Added messages to support changes in PasswordResetModel::verifyPasswordReset
Configuration menu - View commit details
-
Copy full SHA for 6fa6e6e - Browse repository at this point
Copy the full SHA 6fa6e6eView commit details -
Added expirePasswordReset and altered verifyPasswordReset
Added a method named expirePasswordReset to be used with verifyPasswordReset to mark existing password reset requests as expired when it is detected that fake attempts are being used. modified verifyPasswordReset in a few ways. 1. Made the query search for just username instead of the username/verification code combo 2. Added feedback for if user does not exist. 3. Added feedback for if verification code does not exist for selected user 4. Added feedback for if verification code does not match the selected users current code and calls the expirePasswordReset method to current code invalid These changes assume that one bad guess at a verification code is an attempted attack. A better solution might include keeping a tally that way if users click on old link by mistake they don't have to start the process over, but that probably requires using altering the database structure slightly and I don't know if that would be desired, but can be easily added into here if its. Steps need incorporate a tally system: 1. Add field in database users table for number of attempts 2. Add value in config file for max number of attempts 3. Make setPasswordResetDatabaseToken set number of attempts to 0 4. make expirePasswordReset read the current number of attempts. 5.a. make expirePasswordReset update number of attempts 5.b make expirePasswordReset update the timestamp to make it expired
Configuration menu - View commit details
-
Copy full SHA for 4ac1aa5 - Browse repository at this point
Copy the full SHA 4ac1aa5View commit details
Commits on Jan 9, 2016
-
Added password reset attempts counter field
Added field in database user table for counting number of attempts made to reset the their password with the current code.
Configuration menu - View commit details
-
Copy full SHA for ca3edb8 - Browse repository at this point
Copy the full SHA ca3edb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaaafde - Browse repository at this point
Copy the full SHA eaaafdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e81d000 - Browse repository at this point
Copy the full SHA e81d000View commit details
Commits on Jan 16, 2016
-
Removing DB from this branch so that it is in a completed state.
Configuration menu - View commit details
-
Copy full SHA for 6fa779d - Browse repository at this point
Copy the full SHA 6fa779dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.