Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: mitigate the latency issue by prioritizing asynchronous writes #563

Merged
merged 3 commits into from
Mar 31, 2024
Merged

opt: mitigate the latency issue by prioritizing asynchronous writes #563

merged 3 commits into from
Mar 31, 2024

Conversation

panjf2000
Copy link
Owner

@panjf2000 panjf2000 commented Mar 29, 2024 •
edited
Loading

By prioritizing asynchronous writes.

Fixes #423

@github-actions github-actions bot added the enhancement New feature or request label Mar 29, 2024
@panjf2000 panjf2000 added optimization Some small optimizations pending development Requested PR owner to improve code and waiting for the result labels Mar 29, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.08%. Comparing base (ab69eec) to head (efb0d94).
Report is 2 commits behind head on dev.

Files Patch % Lines
engine_unix.go 60.00% 2 Missing ⚠️
acceptor_unix.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #563   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files          25       25           
  Lines        2109     2109           
=======================================
  Hits         1668     1668           
  Misses        305      305           
  Partials      136      136
Flag Coverage Δ
unittests 79.08% <81.25%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 mentioned this pull request Mar 29, 2024
Closed
@panjf2000
Copy link
Owner Author

See also #218, this might bring that old issue back.

@panjf2000 panjf2000 changed the title opt: mitigate the latency issue by prioritizing asynchronous writes feat: add Options.AsyncWriteNoDelay to mitigate the latency issue by prioritizing asynchronous writes Mar 29, 2024
@panjf2000 panjf2000 changed the title feat: add Options.AsyncWriteNoDelay to mitigate the latency issue by prioritizing asynchronous writes feat: add Options.AsyncWriteNoDelay to mitigate the latency issue Mar 29, 2024
@panjf2000 panjf2000 added this to the v2.4 milestone Mar 29, 2024
@panjf2000 panjf2000 changed the title feat: add Options.AsyncWriteNoDelay to mitigate the latency issue opt: mitigate the latency issue by prioritizing asynchronous writes Mar 30, 2024
@panjf2000 panjf2000 merged commit f5e5ef9 into dev Mar 31, 2024
33 checks passed
@panjf2000 panjf2000 deleted the async-write-opt branch March 31, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request new feature optimization Some small optimizations pending development Requested PR owner to improve code and waiting for the result
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

Conn.AsyncWrite() performance tracking
1 participant
@panjf2000