Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: reduce duplicate code of I/O processing #587

Merged
merged 1 commit into from
Apr 22, 2024
Merged

opt: reduce duplicate code of I/O processing #587

merged 1 commit into from
Apr 22, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Apr 22, 2024
@panjf2000 panjf2000 added pending merged This PR has been reviewed and approved optimization Some small optimizations labels Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.67%. Comparing base (39c175b) to head (44fed47).

Files Patch % Lines
reactor_kqueue_default.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #587      +/-   ##
==========================================
+ Coverage   78.61%   79.67%   +1.05%     
==========================================
  Files          23       23              
  Lines        2249     2184      -65     
==========================================
- Hits         1768     1740      -28     
+ Misses        333      304      -29     
+ Partials      148      140       -8     
Flag Coverage Δ
unittests 79.67% <96.66%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 3594d22 into dev Apr 22, 2024
34 checks passed
@panjf2000 panjf2000 deleted the code-opt branch April 22, 2024 04:44
leslie-fei pushed a commit to leslie-fei/gnet that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant