Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix Conn.Next not safe (#648) #649

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

zhongweikang
Copy link
Contributor

1. Are you opening this pull request for bug-fixes, optimizations or new feature?

bug-fixes

2. Please describe how these code changes achieve your intention.

The code was modified at the suggestion of the author。

3. Please link to the relevant issues (if any).

#648

4. Which documentation changes (if any) need to be made/updated because of this PR?

nothing

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

connection_unix.go Outdated Show resolved Hide resolved
connection_windows.go Outdated Show resolved Hide resolved
@panjf2000 panjf2000 added bug Something isn't working pending merged This PR has been reviewed and approved labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (2e261de) to head (8e96be7).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
connection_unix.go 0.00% 3 Missing ⚠️
connection_windows.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #649      +/-   ##
==========================================
+ Coverage   78.57%   78.93%   +0.35%     
==========================================
  Files          21       21              
  Lines        2535     2535              
==========================================
+ Hits         1992     2001       +9     
+ Misses        417      412       -5     
+ Partials      126      122       -4     
Flag Coverage Δ
unittests 78.93% <0.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit cbf7c6a into panjf2000:dev Nov 6, 2024
34 of 35 checks passed
@panjf2000
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants