Remove GenerateToolLockfileSentinel #21225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilatomic
force-pushed
the
refactor/deprecate-GenerateToolLockfileSentinel
branch
from
2075258
to
5ede600
Compare
|
We've just branched for 2.23, so merging this pull request now will come out in 2.24, please move the release notes updates to |
|
I've tripped over the sentinel before so I'm exciting to see this. Would anything in particular help get it ready to land? |
lilatomic
force-pushed
the
refactor/deprecate-GenerateToolLockfileSentinel
branch
from
5ede600
to
604ba3c
Compare
|
This MR removes it, It was already deprecated in #21222 . I was waiting for that one to land and then lost sight of this. We should be good to merge (especially since they're now split across major versions) |
cburroughs
approved these changes
Sep 19, 2024
|
Got it, thanks for doing this! |
By simplifying the logic, we don't need to test for many cases:
- User and Tool lockfiles : all unified
- Tool shadowed by user ("Ambiguous"): happens in the language backend
lilatomic
force-pushed
the
refactor/deprecate-GenerateToolLockfileSentinel
branch
from
3439e5d
to
652bd2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use
ExportableToolinstead ofGenerateToolLockfileSentinelto export internal tools. This results in less boilerplate, a unifying of user and tool lockfiles, and overall less code.This MR removes
GenerateToolLockfileSentineland its codepaths. Simplification!