-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete pymupdf from default_module_mapping.py
#21516
base: main
Are you sure you want to change the base?
Conversation
when we add pymupdf as a dependencies, pants can't find pymupdf. the reason is because now pymupdf no longer expose `fitz` but `pymupdf`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Note comment.
Also, please update docs/notes/2.24.x.md appropriately. Thanks!
src/python/pants/backend/python/dependency_inference/default_module_mapping.py
Show resolved
Hide resolved
@benjyw should be fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor suggested change to the notes, so they fit in better with our typical prose style there. Thanks!
updated notes Co-authored-by: Benjy Weinberger <[email protected]>
@benjyw updated |
I will merge on green CI. Thanks again! |
The package changed it's way to import