-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Custom Fetcher Support to SimpleSDK Constructor #161
Conversation
Hello @mindrunner ! Nice suggestion. Btw, it is already possible to use a custom But having an extra option |
Hi @Velenir, Thank you for your prompt reply.
Certainly, I can create that example. However, integrating Please share your thoughts. I'll proceed with the example in the coming days. Best regards, |
You are right about that. Wdyt? |
Thanks for the example. I added it to the PR! :) |
Great.
A good indication of whether you have reexported everything necessary is whether you can import all you need from /index: //customFetcher.ts
import { constructSimpleSDK, FetcherError, FetcherFunction } from '../'; |
769913c
to
0b41bb9
Compare
absolutely makes sense! Thanks for pointing out. Fixed it :) |
@Velenir Let me know if you need anything else to get this merged! :) |
1 similar comment
@Velenir Let me know if you need anything else to get this merged! :) |
Thank you for pinging me. |
🚀 Description
This PR extends the SimpleSDK class constructor to support custom fetcher functions, allowing it to integrate seamlessly with a variety of HTTP libraries. Importantly, this change is backward-compatible, retaining support for existing axios and fetch configurations.
🤔 Why is this change important?
🛠 Technical Details
Example Implementation (superagent)