Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Workflow & Build Script #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SinaAboutalebi
Copy link

Summary

This pull request includes significant improvements to the GitHub Actions workflow for building an Arch Linux ISO and refines the package list to ensure a more efficient, secure, and maintainable build process.

Workflow Changes

  • Extract common build steps into a reusable job to follow the DRY (Don't Repeat Yourself) principle.
  • Added caching for Pacman packages to speed up the installation process and optimize the workflow.
  • Added continue-on-error: true for the upload step to ensure the workflow proceeds even if the upload fails.
  • Removed redundancy by merging identical steps in both build-beta and build jobs.

…ackage management

- Extract common build steps into a reusable job to follow the DRY principle
- Add error handling for critical steps to ensure robustness
- Secure sensitive information by using GitHub secrets
- Cache Pacman packages to optimize the installation process and speed up workflow
Refactored the build script. Simplified logging with a reusable log function, added package installation, ISO build, and zip creation functions. Ensured the script exits if not run as root, and improved script formatting and comments for better readability.
@SinaAboutalebi
Copy link
Author

Summary

This PR refactors the build script. The main changes include simplifying logging, breaking down the script into smaller functions, and improving overall readability and maintainability.

Changes

  • Logging Improvements
  • Functions Improvements
  • Root User Check
  • Formatting and Comments

@SinaAboutalebi SinaAboutalebi changed the title Refactor Workflow Refactor Workflow & Build Script Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant